Differential D9714 Authored by ashoat on Nov 4 2023, 12:07 PM.
Tags None Referenced Files
Details Summary The new version of Flow wants these function inputs to have typehints. NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.
Depends on D9713 Test Plan Confirm the Flow errors go away
Diff Detail
Event TimelineHerald added subscribers: will, tomek. · View Herald TranscriptNov 4 2023, 12:07 PM2023-11-04 12:07:47 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:42 PM2023-11-04 12:42:27 (UTC-7) This revision is now accepted and ready to land.Nov 6 2023, 1:28 AM2023-11-06 01:28:07 (UTC-8) ashoat retitled this revision from [Flow202][lib] [22/23] Fix Flow issues with untyped conversionFunctions in conversion-utils.js to [Flow202][lib][skip-ci] [22/23] Fix Flow issues with untyped conversionFunctions in conversion-utils.js.Nov 19 2023, 4:55 PM2023-11-19 16:55:32 (UTC-8) This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM2023-11-27 15:25:38 (UTC-8) Closed by commit rCOMM1b19c1c3717e: [Flow202][lib][skip-ci] [22/23] Fix Flow issues with untyped… (authored by ashoat). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33810 |