[Flow202][keyserver][skip-ci] [6/x] Delete some old scripts that haven't been used in a while
ClosedPublic
Actions

Authored by ashoat on Nov 13 2023, 2:57 PM.

Details

Reviewers

atul

Commits

rCOMM28ebcbfccb8f: [Flow202][keyserver][skip-ci] [6/x] Delete some old scripts that haven't been…

Summary

All of these scripts have type errors in the new version of Flow, and I'd rather remove them from the codebase than bother fixing them.

Three of these are ancient migrations from before we had a migration system on keyserver. One of them is an ancient script I don't remember creating.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9853

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 13 2023, 2:57 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 13 2023, 2:57 PM

ashoat added a child revision: D9855: [Flow202][keyserver][skip-ci] [7/x] Address and hide type errors with state sync specs.Nov 13 2023, 2:58 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:09 PM

Harbormaster failed remote builds in B24070: Diff 33168!

ashoat requested review of this revision.Nov 14 2023, 6:15 AM

atul accepted this revision.Nov 14 2023, 12:03 PM

This revision is now accepted and ready to land.Nov 14 2023, 12:03 PM

ashoat retitled this revision from [Flow202][keyserver] [6/x] Delete some old scripts that haven't been used in a while to [Flow202][keyserver][skip-ci] [6/x] Delete some old scripts that haven't been used in a while.Nov 19 2023, 5:06 PM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM

Closed by commit rCOMM28ebcbfccb8f: [Flow202][keyserver][skip-ci] [6/x] Delete some old scripts that haven't been… (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM28ebcbfccb8f: [Flow202][keyserver][skip-ci] [6/x] Delete some old scripts that haven't been….