Page MenuHomePhabricator

[Flow202][native][skip-ci] [8/x] Fix incorrect ReactNav types in navigators & screens
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 5:51 PM
Unknown Object (File)
Oct 19 2024, 2:15 AM
Unknown Object (File)
Oct 19 2024, 2:15 AM
Unknown Object (File)
Oct 19 2024, 2:14 AM
Unknown Object (File)
Oct 19 2024, 2:07 AM
Unknown Object (File)
Oct 15 2024, 8:32 PM
Unknown Object (File)
Sep 13 2024, 3:23 PM
Unknown Object (File)
Sep 1 2024, 12:20 AM
Subscribers
None

Details

Summary

The new version of Flow is stricter with types, and exposed several errors in our typing of navigators and screens.

Some of these are pretty bad, but the good news is that Flow should make sure we don't make the same mistakes again going forward.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9991

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable