Page MenuHomePhabricator

[Flow202][lib][skip-ci] [0/23] Fix Flow issues relating to unsealed objects
ClosedPublic

Authored by ashoat on Nov 4 2023, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 6:56 PM
Unknown Object (File)
Wed, May 1, 3:42 PM
Unknown Object (File)
Tue, Apr 30, 8:40 AM
Unknown Object (File)
Mon, Apr 29, 4:26 PM
Unknown Object (File)
Sun, Apr 28, 2:39 AM
Unknown Object (File)
Thu, Apr 25, 8:41 PM
Unknown Object (File)
Thu, Apr 25, 6:15 PM
Unknown Object (File)
Sun, Apr 21, 11:33 PM
Subscribers

Details

Summary

In older versions of Flow, creating an empty object (eg. const test = {}) resulting in an "unsealed object" type, which had weird quirks and wasn't typechecked as closely.

The new version of Flow changes this behavior. This diff addresses those changes, mostly by introducing types to {} declarations. It also fixes issues that were surfaced after typing the unsealed objects.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9691

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:04 PM
Harbormaster failed remote builds in B23734: Diff 32696!
This revision is now accepted and ready to land.Nov 5 2023, 10:26 AM

Update promiseAll after seeing type errors from other invocations

  1. Prettier fixes for last revision
  2. Update tryflow link in socket.react.js
ashoat retitled this revision from [Flow202][lib] [0/23] Fix Flow issues relating to unsealed objects to [Flow202][lib][skip-ci] [0/23] Fix Flow issues relating to unsealed objects.Nov 19 2023, 11:44 AM