HomePhabricator
Diffusion Comm 2194856a7f38

[Flow202][lib][skip-ci] [0/23] Fix Flow issues relating to unsealed objects

Description

[Flow202][lib][skip-ci] [0/23] Fix Flow issues relating to unsealed objects

Summary:
In older versions of Flow, creating an empty object (eg. const test = {}) resulting in an "unsealed object" type, which had weird quirks and wasn't typechecked as closely.

The new version of Flow changes this behavior. This diff addresses those changes, mostly by introducing types to {} declarations. It also fixes issues that were surfaced after typing the unsealed objects.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9691

Test Plan: Confirm the Flow errors go away

Reviewers: tomek, bartek, atul

Reviewed By: atul

Subscribers: wyilio

Differential Revision: https://phab.comm.dev/D9692

Details

Provenance
ashoatAuthored on Oct 31 2023, 11:39 AM
Reviewer
atul
Differential Revision
D9692: [Flow202][lib][skip-ci] [0/23] Fix Flow issues relating to unsealed objects
Parents
rCOMMde1aac8620c6: [RN72][skip-ci] Update Flow to 0.202.1
Branches
Unknown
Tags
Unknown