HomePhabricator
Diffusion Comm 253f2a13b419

[Flow202][lib][skip-ci] [5/23] Fix Flow issues with missing annotations on…

Description

[Flow202][lib][skip-ci] [5/23] Fix Flow issues with missing annotations on parameters in function declarations

Summary:
The new version of Flow is showing a bunch of errors that look like this:

Error -------------------------------------------------------------------------- components/modal-overlay.react.js:35:51

An annotation on event is required because Flow cannot infer its type from local context. [missing-local-annot]

     32|     }
     33|   }, []);
     34|
     35|   const onBackgroundMouseDown = React.useCallback(event => {
     36|     firstClickRef.current = event.target;
     37|   }, []);
     38|

This diff adds the required annotations.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9696

Test Plan: Confirm the Flow errors go away

Reviewers: tomek

Reviewed By: tomek

Subscribers: wyilio

Differential Revision: https://phab.comm.dev/D9697