Paths

Table of Contentst

Differential D10015

[Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors
ClosedPublic
Actions

Authored by ashoat on Nov 27 2023, 12:50 AM.

Tags

None

Referenced Files

	F3388166: D10015.diff
	Fri, Nov 29, 1:04 PM

	Unknown Object (File)
	Sat, Nov 23, 2:44 PM

	Unknown Object (File)
	Wed, Nov 6, 7:17 AM

	Unknown Object (File)
	Oct 17 2024, 11:49 AM

	Unknown Object (File)
	Oct 17 2024, 11:49 AM

	Unknown Object (File)
	Oct 17 2024, 11:49 AM

	Unknown Object (File)
	Oct 17 2024, 11:49 AM

	Unknown Object (File)
	Oct 8 2024, 6:28 PM

View All 45 Files

Subscribers

None

Details

Reviewers

Commits

rCOMMdb14a28e300e: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors

Summary

The new version of Flow wants more annotations for function and member definitions. This diff adds all of the required annotations to the native codebase necessary to clear all missing-local-annot errors.

This is the native equivalent of D9771 (web), D9697 (lib), and D9873 (keyserver).

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10014

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24456
Build 210172: arc lint + arc unit

Event Timeline

ashoat requested review of this revision.Nov 27 2023, 12:50 AM

ashoat created this revision.

Harbormaster completed remote builds in B24456: Diff 33659.Nov 27 2023, 12:50 AM

ashoat added a child revision: D10016: [Flow202][native][skip-ci] [32/x] Fix type errors in OverlayNavigator.Nov 27 2023, 12:50 AM

tomek accepted this revision.Nov 27 2023, 6:57 AM

This revision is now accepted and ready to land.Nov 27 2023, 6:57 AM

ashoat retitled this revision from t b[Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors to [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors.Nov 27 2023, 8:51 AM

ashoat edited the summary of this revision. (Show Details)

Closed by commit rCOMMdb14a28e300e: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors (authored by ashoat). · Explain WhyNov 27 2023, 3:28 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMdb14a28e300e: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors.

Revision Contents
Changeset List

Path

Size

native/

account/

logged-out-modal.react.js

10 lines

register-panel.react.js

4 lines

registration/

emoji-avatar-selection.react.js

3 lines

12 lines

siwe-panel.react.js

10 lines

avatars/

emoji-avatar-creation.react.js

5 lines

calendar/

calendar.react.js

50 lines

section-footer.react.js

2 lines

chat/

chat-input-bar.react.js

29 lines

chat-list.react.js

8 lines

44 lines

failed-send.react.js

2 lines

message-list-container.react.js

4 lines

message-list-header-title.react.js

2 lines

message-list.react.js

49 lines

message-reactions-modal.react.js

7 lines

multimedia-message-multimedia.react.js

10 lines

multimedia-message-tooltip-button.react.js

3 lines

multimedia-message-tooltip-modal.react.js

15 lines

multimedia-message.react.js

8 lines

robotext-message-tooltip-button.react.js

3 lines

robotext-message-tooltip-modal.react.js

3 lines

robotext-message.react.js

9 lines

settings/

compose-subchannel-modal.react.js

2 lines

delete-thread.react.js

4 lines

emoji-thread-avatar-creation.react.js

3 lines

thread-settings-color.react.js

2 lines

thread-settings-description.react.js

8 lines

thread-settings-home-notifs.react.js

2 lines

thread-settings-leave-thread.react.js

4 lines

thread-settings-media-gallery.react.js

2 lines

thread-settings-member.react.js

4 lines

thread-settings-name.react.js

10 lines

thread-settings-promote-sidebar.react.js

2 lines

thread-settings-push-notifs.react.js

2 lines

thread-settings.react.js

955 lines

text-message-tooltip-button.react.js

3 lines

text-message-tooltip-modal.react.js

23 lines

text-message.react.js

10 lines

thread-settings-button.react.js

2 lines

community-creation/

community-configuration.react.js

2 lines

components/

emoji-keyboard.react.js

2 lines

full-screen-view-modal.react.js

30 lines

keyboard-avoiding-view.react.js

4 lines

link-button.react.js

2 lines

node-height-measurer.react.js

2 lines

selectable-text-input.react.ios.js

2 lines

selectable-text-input.react.js

2 lines

tag-input.react.js

2 lines

thread-list-thread.react.js

2 lines

thread-list.react.js

47 lines

user-list-user.react.js

2 lines

user-list.react.js

8 lines

6 lines

input/

input-state-container.react.js

31 lines

keyboard/

keyboard-input-host.react.js

4 lines

media/

camera-modal.react.js

81 lines

media-gallery-keyboard.react.js

20 lines

2 lines

multimedia.react.js

8 lines

remote-image.react.js

2 lines

2 lines

video-playback-modal.react.js

25 lines

navigation/

community-drawer-content.react.js

8 lines

nav-selectors.js

8 lines

orientation-handler.react.js

4 lines

root-navigator.react.js

9 lines

tab-bar.react.js

4 lines

tab-navigator.react.js

8 lines

profile/

appearance-preferences.react.js

2 lines

backup-menu.react.js

2 lines

custom-server-modal.react.js

2 lines

default-notifications-preferences.react.js

2 lines

dev-tools.react.js

4 lines

edit-password.react.js

2 lines

emoji-user-avatar-creation.react.js

3 lines

keyserver-selection-list.react.js

7 lines

profile-screen.react.js

4 lines

profile.react.js

3 lines

relationship-list-item.react.js

11 lines

relationship-list.react.js

4 lines

toggle-report.react.js

2 lines

push/

push-handler.react.js

6 lines

redux/

client-db-utils.js

11 lines

connectivity-updater.react.js

13 lines

89 lines

update-roles-and-permissions.js

2 lines

roles/

roles-navigator.react.js

3 lines

search/

message-search.react.js

2 lines

tooltip/

tooltip.react.js

31 lines

utils/

typeahead-utils.js

19 lines

Diff 33659

native/account/logged-out-modal.react.js

Loading...

native/account/register-panel.react.js

Loading...

native/account/registration/emoji-avatar-selection.react.js

Loading...

native/account/siwe-hooks.js

Loading...

native/account/siwe-panel.react.js

Loading...

native/avatars/emoji-avatar-creation.react.js

Loading...

native/calendar/calendar.react.js

Loading...

native/calendar/section-footer.react.js

Loading...

native/chat/chat-input-bar.react.js

Loading...

native/chat/chat-list.react.js

Loading...

native/chat/chat.react.js

Loading...

native/chat/failed-send.react.js

Loading...

native/chat/message-list-container.react.js

Loading...

native/chat/message-list-header-title.react.js

Loading...

native/chat/message-list.react.js

Loading...

native/chat/message-reactions-modal.react.js

Loading...

native/chat/multimedia-message-multimedia.react.js

Loading...

native/chat/multimedia-message-tooltip-button.react.js

Loading...

native/chat/multimedia-message-tooltip-modal.react.js

Loading...

native/chat/multimedia-message.react.js

Loading...

native/chat/robotext-message-tooltip-button.react.js

Loading...

native/chat/robotext-message-tooltip-modal.react.js

Loading...

native/chat/robotext-message.react.js

Loading...

native/chat/settings/compose-subchannel-modal.react.js

Loading...

native/chat/settings/delete-thread.react.js

Loading...

native/chat/settings/emoji-thread-avatar-creation.react.js

Loading...

native/chat/settings/thread-settings-color.react.js

Loading...

native/chat/settings/thread-settings-description.react.js

Loading...

native/chat/settings/thread-settings-home-notifs.react.js

Loading...

native/chat/settings/thread-settings-leave-thread.react.js

Loading...

native/chat/settings/thread-settings-media-gallery.react.js

Loading...

native/chat/settings/thread-settings-member.react.js

Loading...

native/chat/settings/thread-settings-name.react.js

Loading...

native/chat/settings/thread-settings-promote-sidebar.react.js

Loading...

native/chat/settings/thread-settings-push-notifs.react.js

Loading...

native/chat/settings/thread-settings.react.js

Loading...

native/chat/text-message-tooltip-button.react.js

Loading...

native/chat/text-message-tooltip-modal.react.js

Loading...

native/chat/text-message.react.js

Loading...

native/chat/thread-settings-button.react.js

Loading...

native/community-creation/community-configuration.react.js

Loading...

native/components/emoji-keyboard.react.js

Loading...

native/components/full-screen-view-modal.react.js

Loading...

native/components/keyboard-avoiding-view.react.js

Loading...

native/components/link-button.react.js

Loading...

native/components/node-height-measurer.react.js

Loading...

native/components/selectable-text-input.react.ios.js

Loading...

native/components/selectable-text-input.react.js

Loading...

native/components/tag-input.react.js

Loading...

native/components/thread-list-thread.react.js

Loading...

native/components/thread-list.react.js

Loading...

native/components/user-list-user.react.js

Loading...

native/components/user-list.react.js

Loading...

native/crash.react.js

Loading...

native/input/input-state-container.react.js

Loading...

native/keyboard/keyboard-input-host.react.js

Loading...

native/media/camera-modal.react.js

Loading...

native/media/media-gallery-keyboard.react.js

Loading...

native/media/media-utils.js

Loading...

native/media/multimedia.react.js

Loading...

native/media/remote-image.react.js

Loading...

native/media/save-media.js

Loading...

native/media/video-playback-modal.react.js

Loading...

native/navigation/community-drawer-content.react.js

Loading...

native/navigation/nav-selectors.js

Loading...

native/navigation/orientation-handler.react.js

Loading...

native/navigation/root-navigator.react.js

Loading...

native/navigation/tab-bar.react.js

Loading...

native/navigation/tab-navigator.react.js

Loading...

native/profile/appearance-preferences.react.js

Loading...

native/profile/backup-menu.react.js

Loading...

native/profile/custom-server-modal.react.js

Loading...

native/profile/default-notifications-preferences.react.js

Loading...

native/profile/dev-tools.react.js

Loading...

native/profile/edit-password.react.js

Loading...

native/profile/emoji-user-avatar-creation.react.js

Loading...

native/profile/keyserver-selection-list.react.js

Loading...

native/profile/profile-screen.react.js

Loading...

native/profile/profile.react.js

Loading...

native/profile/relationship-list-item.react.js

Loading...

native/profile/relationship-list.react.js

Loading...

native/profile/toggle-report.react.js

Loading...

native/push/push-handler.react.js

Loading...

native/redux/client-db-utils.js

Loading...

native/redux/connectivity-updater.react.js

Loading...

native/redux/persist.js

Loading...

native/redux/update-roles-and-permissions.js

Loading...

native/roles/roles-navigator.react.js

Loading...

native/search/message-search.react.js

Loading...

native/tooltip/tooltip.react.js

Loading...

native/utils/typeahead-utils.js

Loading...