HomePhabricator
Diffusion Comm 2fdcadd5facc

[lib] Avoid regenerating holdersToRemove whenever Redux state changes

Description

[lib] Avoid regenerating holdersToRemove whenever Redux state changes

Summary:
This diff addresses ENG-9391: Maximum update depth exceeded.

The way this code was written, whenever the Redux state changed, holdersToRemove would be regenerated. This led to a React render loop.

Test Plan: Confirm that the React render cycle goes away

Reviewers: bartek, kamil, tomek, varun, will

Reviewed By: varun

Differential Revision: https://phab.comm.dev/D13465

Details

Provenance
ashoatAuthored on Wed, Sep 25, 10:36 AM
Reviewer
varun
Differential Revision
D13465: [lib] Avoid regenerating holdersToRemove whenever Redux state changes
Parents
rCOMM07fa6f5e9cba: [terraform] Use JSON logs in Blob Cleanup task
Branches
Unknown
Tags
Unknown