Page MenuHomePhabricator
Differential D13465

[lib] Avoid regenerating holdersToRemove whenever Redux state changes
ClosedPublic
Actions

Authored by ashoat on Sep 25 2024, 10:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 10, 3:17 PM
Unknown Object (File)
Mon, Mar 10, 3:15 PM
Unknown Object (File)
Mon, Mar 10, 3:13 PM
Unknown Object (File)
Mon, Mar 10, 2:43 PM
Unknown Object (File)
Jan 18 2025, 8:55 AM
Unknown Object (File)
Jan 6 2025, 6:08 PM
Unknown Object (File)
Jan 1 2025, 6:57 AM
Unknown Object (File)
Jan 1 2025, 6:57 AM
View All 43 Files
Subscribers
None

Details

Reviewers
bartek
kamil
tomek
varun
will
Commits
rCOMM2fdcadd5facc: [lib] Avoid regenerating holdersToRemove whenever Redux state changes
Summary

This diff addresses ENG-9391: Maximum update depth exceeded.

The way this code was written, whenever the Redux state changed, holdersToRemove would be regenerated. This led to a React render loop.

Test Plan

Confirm that the React render cycle goes away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
actions/
11 lines

Diff 44564

View Options

lib/actions/holder-actions.js

  • This file was added.
# VPC
resource "aws_vpc" "default" {
cidr_block = "172.31.0.0/16"
enable_dns_support = true
enable_dns_hostnames = true
}
# Public Subnets
resource "aws_subnet" "public_a" {
vpc_id = aws_vpc.default.id
cidr_block = "172.31.0.0/20"
availability_zone = "us-east-2a"
map_public_ip_on_launch = true
}
resource "aws_subnet" "public_b" {
vpc_id = aws_vpc.default.id
cidr_block = "172.31.16.0/20"
availability_zone = "us-east-2b"
map_public_ip_on_launch = true
}
# Internet Gateway
resource "aws_internet_gateway" "default" {
vpc_id = aws_vpc.default.id
}
# Route Table for Internet Gateway
resource "aws_route_table" "public_igw_route_table" {
vpc_id = aws_vpc.default.id
route {
cidr_block = "0.0.0.0/0"
gateway_id = aws_internet_gateway.default.id
}
}
resource "aws_route_table_association" "public_a_igw_route_association" {
subnet_id = aws_subnet.public_a.id
route_table_id = aws_route_table.public_igw_route_table.id
}
resource "aws_route_table_association" "public_b_igw_route_association" {
subnet_id = aws_subnet.public_b.id
route_table_id = aws_route_table.public_igw_route_table.id
}