Paths

Table of Contentst

Differential D13465

[lib] Avoid regenerating holdersToRemove whenever Redux state changes
ClosedPublic
Actions

Authored by ashoat on Wed, Sep 25, 10:39 AM.

Tags

None

Referenced Files

	F2842636: D13465.id44564.diff
	Sun, Sep 29, 3:04 PM

	Unknown Object (File)
	Sat, Sep 28, 3:45 AM

	Unknown Object (File)
	Wed, Sep 25, 12:22 PM

	Unknown Object (File)
	Wed, Sep 25, 12:22 PM

	Unknown Object (File)
	Wed, Sep 25, 12:21 PM

	Unknown Object (File)
	Wed, Sep 25, 12:04 PM

Subscribers

None

Details

Reviewers

bartek
kamil
tomek
varun
will

Commits

rCOMM2fdcadd5facc: [lib] Avoid regenerating holdersToRemove whenever Redux state changes

Summary

This diff addresses ENG-9391: Maximum update depth exceeded.

The way this code was written, whenever the Redux state changed, holdersToRemove would be regenerated. This led to a React render loop.

Test Plan

Confirm that the React render cycle goes away

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Wed, Sep 25, 10:39 AM

Harbormaster completed remote builds in B31848: Diff 44558.Wed, Sep 25, 11:01 AM

ashoat requested review of this revision.Wed, Sep 25, 11:01 AM

varun accepted this revision.Wed, Sep 25, 11:29 AM

This revision is now accepted and ready to land.Wed, Sep 25, 11:29 AM

Closed by commit rCOMM2fdcadd5facc: [lib] Avoid regenerating holdersToRemove whenever Redux state changes (authored by ashoat). · Explain WhyWed, Sep 25, 12:00 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2fdcadd5facc: [lib] Avoid regenerating holdersToRemove whenever Redux state changes.

Revision Contents
Changeset List

Path

Size

lib/

actions/

holder-actions.js

11 lines

Diff 44564

lib/actions/holder-actions.js

Loading...