Page MenuHomePhabricator

[lib] Avoid regenerating holdersToRemove whenever Redux state changes
ClosedPublic

Authored by ashoat on Sep 25 2024, 10:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 8:38 PM
Unknown Object (File)
Thu, Dec 5, 8:38 PM
Unknown Object (File)
Thu, Dec 5, 8:35 PM
Unknown Object (File)
Thu, Dec 5, 8:13 PM
Unknown Object (File)
Nov 23 2024, 6:03 AM
Unknown Object (File)
Nov 23 2024, 5:26 AM
Unknown Object (File)
Nov 23 2024, 2:31 AM
Unknown Object (File)
Nov 16 2024, 7:58 PM
Subscribers
None

Details

Summary

This diff addresses ENG-9391: Maximum update depth exceeded.

The way this code was written, whenever the Redux state changed, holdersToRemove would be regenerated. This led to a React render loop.

Test Plan

Confirm that the React render cycle goes away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable