HomePhabricator
Diffusion Comm 360d7061a36b

[keyserver] check if viewer role is positive for updateThread

Description

[keyserver] check if viewer role is positive for updateThread

Summary:
Was running into an issue where because the viewer was constructed as a script viewer, it couldn't be added to the community thread with joinThread as fetchViewerIsMember always returns that script viewers are members. This diff
instead replaces the is a member check with a check for if the viewer role is positive, which will allow us to add script viewers to the thread.

Discussion at https://linear.app/comm/issue/ENG-8457/create-comm-community-for-a-farcaster-channel-if-it-doesnt-already

Depends on D13775

Test Plan: Was able to successfully add commbot and a test comm user to the community thread. Subsequent attempts to add did not result in duplicate robotext

Reviewers: ashoat, varun

Reviewed By: ashoat

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D13815

Details

Provenance
willAuthored on Oct 29 2024, 11:17 PM
Reviewer
ashoat
Differential Revision
D13815: [keyserver] check if viewer role is positive for updateThread
Parents
rCOMM818349ebd001: [keyserver] add community creation logic to farcaster webhook responder
Branches
Unknown
Tags
Unknown