Page MenuHomePhabricator
Differential D13815

[keyserver] check if viewer role is positive for updateThread
ClosedPublic
Actions

Authored by will on Tue, Oct 29, 11:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 4:58 AM
Unknown Object (File)
Fri, Nov 15, 4:57 AM
Unknown Object (File)
Fri, Nov 15, 2:06 AM
Unknown Object (File)
Thu, Nov 14, 6:55 PM
Unknown Object (File)
Thu, Nov 14, 3:59 PM
Unknown Object (File)
Thu, Nov 14, 2:53 PM
Unknown Object (File)
Thu, Nov 14, 2:51 PM
Unknown Object (File)
Mon, Nov 11, 12:00 PM
View All 29 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMM360d7061a36b: [keyserver] check if viewer role is positive for updateThread
Summary

Was running into an issue where because the viewer was constructed as a script viewer, it couldn't be added to the community thread with joinThread as fetchViewerIsMember always returns that script viewers are members. This diff
instead replaces the is a member check with a check for if the viewer role is positive, which will allow us to add script viewers to the thread.

Discussion at https://linear.app/comm/issue/ENG-8457/create-comm-community-for-a-farcaster-channel-if-it-doesnt-already

Depends on D13775

Test Plan

Was able to successfully add commbot and a test comm user to the community thread. Subsequent attempts to add did not result in duplicate robotext

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Tue, Oct 29, 11:25 PM
Herald added a subscriber: tomek. · View Herald TranscriptTue, Oct 29, 11:25 PM
will edited the summary of this revision. (Show Details)Tue, Oct 29, 11:26 PM
will added a parent revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.
will mentioned this in D13782: [keyserver] create message and sidebar based on cast.
will added a child revision: D13782: [keyserver] create message and sidebar based on cast.
Harbormaster completed remote builds in B32424: Diff 45451.Tue, Oct 29, 11:43 PM
will requested review of this revision.Tue, Oct 29, 11:43 PM
will added a child revision: D13816: [keyserver] add dontAddViewerAsMember to createThread.Wed, Oct 30, 12:13 AM
will removed a child revision: D13782: [keyserver] create message and sidebar based on cast.Wed, Oct 30, 12:15 AM
ashoat accepted this revision.Wed, Oct 30, 4:38 AM
ashoat added inline comments.
keyserver/src/updaters/thread-updaters.js
61 ↗(On Diff #45451)

We don't need this as rename anymore. It previously there because something named viewerIsMember is already imported (line 10)

This revision is now accepted and ready to land.Wed, Oct 30, 4:38 AM
will removed a child revision: D13816: [keyserver] add dontAddViewerAsMember to createThread.Wed, Oct 30, 10:11 AM
will added a child revision: D13782: [keyserver] create message and sidebar based on cast.Wed, Oct 30, 11:12 AM
will added inline comments.Wed, Oct 30, 1:45 PM
keyserver/src/updaters/thread-updaters.js
61 ↗(On Diff #45451)

Included in latest rebase

will updated this revision to Diff 45491.Wed, Oct 30, 1:45 PM

remove as

will marked an inline comment as done.Wed, Oct 30, 1:46 PM
Harbormaster completed remote builds in B32458: Diff 45491.Wed, Oct 30, 2:43 PM
Closed by commit rCOMM360d7061a36b: [keyserver] check if viewer role is positive for updateThread (authored by will). · Explain WhyThu, Oct 31, 12:19 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM360d7061a36b: [keyserver] check if viewer role is positive for updateThread.
will mentioned this in rCOMM65ca88236580: [keyserver] create message and sidebar based on cast.

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
16 lines
updaters/
4 lines

Diff 45562

View Options

keyserver/src/fetchers/thread-permission-fetchers.js

Loading...
View Options

keyserver/src/updaters/thread-updaters.js

Loading...