Page MenuHomePhabricator
Differential D13774

[keyserver] implemented FarcasterChannelTagBlob type for upload payload with validator
ClosedPublic
Actions

Authored by will on Oct 22 2024, 9:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 2:51 PM
Unknown Object (File)
Wed, Nov 27, 1:54 PM
Unknown Object (File)
Nov 23 2024, 5:37 AM
Unknown Object (File)
Nov 22 2024, 5:29 PM
Unknown Object (File)
Nov 22 2024, 5:29 PM
Unknown Object (File)
Nov 22 2024, 5:29 PM
Unknown Object (File)
Nov 22 2024, 5:28 PM
Unknown Object (File)
Nov 18 2024, 3:51 PM
View All 31 Files
Subscribers
bartek
tomek

Details

Reviewers
varun
ashoat
Commits
rCOMM4204d20c64d4: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with…
Summary

Made a type for the FarcasterChannelTagBlob upload payload with a validator.

Later in the stack, I'll be downloading this blob and will need to validate to ensure proper type checking

Depends on D13773

Test Plan

flow check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Oct 22 2024, 9:24 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 22 2024, 9:24 PM
Harbormaster completed remote builds in B32343: Diff 45332.Oct 22 2024, 9:43 PM
will requested review of this revision.Oct 22 2024, 9:43 PM
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 22 2024, 9:44 PM
will added inline comments.Oct 22 2024, 9:53 PM
keyserver/src/creators/farcaster-channel-tag-creator.js
149–154 ↗(On Diff #45332)

Unsure if this is the right place to put it. Maybe lib/utils/farcaster-utils.js?

ashoat accepted this revision.Oct 23 2024, 5:40 AM
ashoat added inline comments.
keyserver/src/creators/farcaster-channel-tag-creator.js
149–154 ↗(On Diff #45332)

Might be better. Do you think it'll be used outside of keyserver?

This revision is now accepted and ready to land.Oct 23 2024, 5:40 AM
will added a child revision: D13781: [keyserver] add comm config for authoritative facaster bot boolean variable.Oct 23 2024, 9:19 PM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 23 2024, 9:20 PM
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 23 2024, 9:24 PM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 23 2024, 9:39 PM
will added a subscriber: bartek.Oct 28 2024, 9:07 PM
will added inline comments.
keyserver/src/creators/farcaster-channel-tag-creator.js
149–154 ↗(On Diff #45332)

Unsure. I don't think so but this might be a question for @varun or @bartek

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 29 2024, 2:24 PM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 29 2024, 4:52 PM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 29 2024, 11:30 PM
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 11:10 AM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 1:07 PM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 1:31 PM
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 6:10 PM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 31 2024, 7:17 AM
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 31 2024, 9:25 AM
will added inline comments.Oct 31 2024, 11:44 AM
keyserver/src/creators/farcaster-channel-tag-creator.js
149–154 ↗(On Diff #45332)

Going to keep this in here for now. Can't think of an example right now where clients would use this

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 31 2024, 12:07 PM
Closed by commit rCOMM4204d20c64d4: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with… (authored by will). · Explain WhyOct 31 2024, 12:19 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM4204d20c64d4: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with….

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
24 lines

Diff 45554

View Options

keyserver/src/creators/farcaster-channel-tag-creator.js

Loading...