Paths

Table of Contentst

[keyserver] implemented FarcasterChannelTagBlob type for upload payload with validator
ClosedPublic
Actions

Authored by will on Oct 23 2024, 4:24 AM.

Details

Reviewers

varun
ashoat

Commits

rCOMM4204d20c64d4: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with…

Summary

Made a type for the FarcasterChannelTagBlob upload payload with a validator.

Later in the stack, I'll be downloading this blob and will need to validate to ensure proper type checking

Depends on D13773

Test Plan

flow check

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Oct 23 2024, 4:24 AM

Herald added a subscriber: tomek. · View Herald TranscriptOct 23 2024, 4:24 AM

Harbormaster completed remote builds in B32343: Diff 45332.Oct 23 2024, 4:43 AM

will requested review of this revision.Oct 23 2024, 4:43 AM

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 23 2024, 4:44 AM

will added inline comments.Oct 23 2024, 4:53 AM

keyserver/src/creators/farcaster-channel-tag-creator.js
149–154 ↗	(On Diff #45332)	Unsure if this is the right place to put it. Maybe `lib/utils/farcaster-utils.js`?

ashoat accepted this revision.Oct 23 2024, 12:40 PM

ashoat added inline comments.

keyserver/src/creators/farcaster-channel-tag-creator.js
149–154 ↗	(On Diff #45332)	Might be better. Do you think it'll be used outside of `keyserver`?

This revision is now accepted and ready to land.Oct 23 2024, 12:40 PM

will added a child revision: D13781: [keyserver] add comm config for authoritative facaster bot boolean variable.Oct 24 2024, 4:19 AM

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 24 2024, 4:20 AM

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 24 2024, 4:24 AM

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 24 2024, 4:39 AM

will added a subscriber: bartek.Oct 29 2024, 4:07 AM

will added inline comments.

keyserver/src/creators/farcaster-channel-tag-creator.js
149–154 ↗	(On Diff #45332)	Unsure. I don't think so but this might be a question for @varun or @bartek

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 29 2024, 9:24 PM

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 29 2024, 11:52 PM

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 6:30 AM

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 6:10 PM

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 8:07 PM

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 30 2024, 8:31 PM

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 31 2024, 1:10 AM

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 31 2024, 2:17 PM

will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 31 2024, 4:25 PM

will added inline comments.Oct 31 2024, 6:44 PM

keyserver/src/creators/farcaster-channel-tag-creator.js
149–154 ↗	(On Diff #45332)	Going to keep this in here for now. Can't think of an example right now where clients would use this

will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Oct 31 2024, 7:07 PM

Closed by commit rCOMM4204d20c64d4: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with…. · Explain WhyOct 31 2024, 7:19 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM4204d20c64d4: [keyserver] implemented FarcasterChannelTagBlob type for upload payload with….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

farcaster-channel-tag-creator.js

24 lines

Diff 45554

View Options

keyserver/src/creators/farcaster-channel-tag-creator.js

[keyserver] implemented FarcasterChannelTagBlob type for upload payload with validatorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45554

keyserver/src/creators/farcaster-channel-tag-creator.js

[keyserver] implemented FarcasterChannelTagBlob type for upload payload with validator
ClosedPublic
Actions

Revision Contents
Changeset List