Page MenuHomePhabricator
Differential D13832

[keyserver] do not filter by role in fetchCommunityInfos calls for script viewers
ClosedPublic
Actions

Authored by will on Oct 30 2024, 12:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 22, 9:32 AM
Unknown Object (File)
Mon, Mar 17, 9:46 PM
Unknown Object (File)
Mon, Mar 17, 9:27 PM
Unknown Object (File)
Mon, Mar 17, 9:30 AM
Unknown Object (File)
Mon, Mar 17, 9:03 AM
Unknown Object (File)
Fri, Mar 14, 5:36 AM
Unknown Object (File)
Tue, Mar 11, 7:05 AM
Unknown Object (File)
Tue, Mar 11, 7:02 AM
View All 68 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMMd395d144ab4c: [keyserver] do not filter by role in fetchCommunityInfos calls for script…
Summary

This allows script viewers to receive all community infos irregardless of their role/membership. This work resulted from calling createOrUpdateFarcasterChannelTag with a ghost commbot viewer which resulted in not being able to find the farcaster channel's community info and then a resulting invalid_parameter error

Depends on D13819

Test Plan

This resolved tagging of the farcaster channel community by commbot later in the stack as the function was able to properly fetch the community info

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
24 lines

Diff 45558

View Options

keyserver/src/fetchers/community-fetchers.js

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Lines (actionCurrentUserInfo === null ||
(actionCurrentUserInfo && actionCurrentUserInfo.anonymous)) && (actionCurrentUserInfo && actionCurrentUserInfo.anonymous)) &&
preRequestUserState && preRequestUserState &&
(preRequestUserState.currentUserInfo?.id !== currentCurrentUserInfo.id || (preRequestUserState.currentUserInfo?.id !== currentCurrentUserInfo.id ||
preRequestUserState.commServicesAccessToken !== preRequestUserState.commServicesAccessToken !==
currentReduxState.commServicesAccessToken) currentReduxState.commServicesAccessToken)
); );
} }
// actionCurrentUserInfo can either be the CurrentUserInfo at the time the
// recovery began (preRequestUserInfo), or the CurrentUserInfo in the action.
// We expect that for a recovery they should be the same. The intention is to
// make sure that the CurrentUserInfo in Redux at the time this action is
// processed is the same as the user from whom the recovery was attempted. If
// that user has since logged out, we should ignore the result of the recovery.
const actionSourcesCheckedForInvalidSessionRecovery = new Set([
recoveryActionSources.cookieInvalidationResolutionAttempt,
recoveryActionSources.socketAuthErrorResolutionAttempt,
recoveryActionSources.appStartCookieLoggedInButInvalidRedux,
recoveryActionSources.appStartReduxLoggedInButInvalidCookie,
recoveryActionSources.refetchUserDataAfterAcknowledgment,
recoveryActionSources.socketNotLoggedIn,
]);
function invalidSessionRecovery( function invalidSessionRecovery(
currentReduxState: AppState, currentReduxState: AppState,
actionCurrentUserInfo: ?CurrentUserInfo, actionCurrentUserInfo: ?CurrentUserInfo,
authActionSource: ?AuthActionSource, authActionSource: ?AuthActionSource,
): boolean { ): boolean {
if ( if (
authActionSource !== !authActionSource ||
recoveryActionSources.cookieInvalidationResolutionAttempt && !actionSourcesCheckedForInvalidSessionRecovery.has(authActionSource)
authActionSource !== recoveryActionSources.socketAuthErrorResolutionAttempt
) { ) {
return false; return false;
} }
invariant( invariant(
actionCurrentUserInfo, actionCurrentUserInfo,
'currentUserInfo (preRequestUserInfo) should be defined when ' + 'actionCurrentUserInfo should be passed to invalidSessionRecovery for ' +
'COOKIE_INVALIDATION_RESOLUTION_ATTEMPT or ' + `${authActionSource} login`,
'SOCKET_AUTH_ERROR_RESOLUTION_ATTEMPT login is dispatched',
); );
if (actionCurrentUserInfo.anonymous) { if (actionCurrentUserInfo.anonymous) {
// It's not a session recovery if the CurrentUserInfo is anonymous // It's not a session recovery if the CurrentUserInfo is anonymous
return false; return false;
} }
return ( return (
!currentReduxState.dataLoaded || !currentReduxState.dataLoaded ||
currentReduxState.currentUserInfo?.id !== actionCurrentUserInfo.id currentReduxState.currentUserInfo?.id !== actionCurrentUserInfo.id
); );
} }
export { export {
invalidSessionDowngrade, invalidSessionDowngrade,
identityInvalidSessionDowngrade, identityInvalidSessionDowngrade,
invalidSessionRecovery, invalidSessionRecovery,
}; };