HomePhabricator
Diffusion Comm 38684f16525b

[web] fixup pinned message modal

Description

[web] fixup pinned message modal

Summary:
As I was cleaning up the pinned message modal, I noticed several things not working properly with this modal.

  • If you unpinned a message from within the modal, the title of the modal would not update to reflect the correct number of pinned messages in the chat
  • If there were no pinned messages in the modal, there was no text/output to indicate to the user that the list was empty

Linear task: https://linear.app/comm/issue/ENG-5945/fix-up-pinned-messages-modal

Depends on D10347

Test Plan:
Please see the demo video below

Reviewers: atul, rohan, kamil

Reviewed By: rohan

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10348

Details

Provenance
ginsuAuthored on Jan 4 2024, 7:58 PM
Reviewer
rohan
Differential Revision
D10348: [web] fixup pinned message modal
Parents
rCOMM7d8837fc824e: [lib/native/web] introduce pinnedMessageCountText function
Branches
Unknown
Tags
Unknown