Page MenuHomePhabricator

[web] fixup pinned message modal
ClosedPublic

Authored by ginsu on Dec 15 2023, 12:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 8 2024, 11:46 PM
Unknown Object (File)
Apr 8 2024, 11:46 PM
Unknown Object (File)
Apr 8 2024, 11:46 PM
Unknown Object (File)
Apr 8 2024, 11:45 PM
Unknown Object (File)
Apr 8 2024, 11:43 PM
Unknown Object (File)
Mar 6 2024, 11:10 PM
Unknown Object (File)
Mar 6 2024, 11:09 PM
Unknown Object (File)
Mar 6 2024, 11:09 PM
Subscribers

Details

Summary

As I was cleaning up the pinned message modal, I noticed several things not working properly with this modal.

  • If you unpinned a message from within the modal, the title of the modal would not update to reflect the correct number of pinned messages in the chat
  • If there were no pinned messages in the modal, there was no text/output to indicate to the user that the list was empty

Linear task: https://linear.app/comm/issue/ENG-5945/fix-up-pinned-messages-modal

Depends on D10347

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Dec 15 2023, 1:34 AM

Thanks for fixing this!

This revision is now accepted and ready to land.Dec 15 2023, 8:14 AM
This revision was automatically updated to reflect the committed changes.