HomePhabricator
Diffusion Comm 38896494b582

[lib] correctly skip using established socket when urlPrefix is overriden

Description

[lib] correctly skip using established socket when urlPrefix is overriden

Summary:
In D9667, I got some feedback about improving the solution for not using an established socket for calling endpoints whenever we override the urlPrefix. This diff addresses that feedback.

Depends on D9667

Test Plan:
Created this dummy params override object:

const dummyOverride = {
  urlPrefixOverride: 'testing',
};

And passed it to endpoint calls that would normally use an established socket and confirmed that when we overrode the url prefix with this dummy params override object we were not entering the condition in callServerEndpoint where we use an established socket

Reviewers: inka, michal, rohan, ashoat

Reviewed By: inka, ashoat

Subscribers: ashoat, tomek, wyilio

Differential Revision: https://phab.comm.dev/D9673

Details

Provenance
ginsuAuthored on Dec 6 2023, 12:55 PM
Reviewer
inka
Differential Revision
D9673: [lib] correctly skip using established socket when urlPrefix is overriden
Parents
rCOMM842832efd32f: [lib/native] Show resolved ENS name in user profile
Branches
Unknown
Tags
Unknown