HomePhabricator
Diffusion Comm 3a00dcd2e347

[native] introduce block action to relationship list item tooltip menu

Description

[native] introduce block action to relationship list item tooltip menu

Summary:
This stack will finish up the functionality for the user profile menu button. When a user presses on the menu button, we expect that a tooltip menu will pop up with some relationship actions (blocking, unfriending, etc). We already have RelationshipListItemTooltipModal which does exactly what we need but we need to make a few tweaks to this in order to make RelationshipListItemTooltipModal more general purpose and work for the case of both the RelationshipListItem as well as the UserProfile.

Screenshot 2023-10-05 at 4.44.56 PM.png (1×1 px, 170 KB)

This is step 1 in the list below
Outlined below are the steps I will take to update RelationshipListItemTooltipModal:

  1. Add the block action to relationship list item tooltip menu (RelationshipListItem won't need this option, but User profiles will. This is shown in the figma screenshot above)
  2. Rename RelationshipListItemTooltipModal to something more generic like UserRelationshipTooltipModal
  3. Make UserRelationshipTooltipButton into a functional component (We need to use the useColors hook in a subsequent diff)
  4. Introduce the tooltipButtonIcon as a param to RelationshipListItemTooltipModal (RelationshipListItem will use a pencil icon and user profiles will use a kebab menu icon)
  5. Introduce UserProfileMenuButton (This component will handle navigating to RelationshipListItemTooltipModal

Depends on D9377

Test Plan:
Confirmed that RelationshipListItem does not have the block action (this is expected since block was not added to the visibleEntryIDs in RelationshipListItem), but here is what it is going to look like in the user profile (introduced later in this stack)

RelationshipListItem:

Screenshot 2023-10-05 at 4.47.29 PM.png (1×1 px, 300 KB)

User Profile:

Reviewers: atul, inka

Reviewed By: atul

Subscribers: ashoat, tomek, wyilio

Differential Revision: https://phab.comm.dev/D9378

Details

Provenance
ginsuAuthored on Sep 24 2023, 6:33 PM
Reviewer
atul
Differential Revision
D9378: [native] introduce block action to relationship list item tooltip menu
Parents
rCOMM720d97ea0426: [native] introduce UserProfileAvatar
Branches
Unknown
Tags
Unknown