HomePhabricator
Diffusion Comm 3c29c0069646

[native] Fix issue with `ColorSelector` header color

Description

[native] Fix issue with ColorSelector header color

Summary:
Context: https://linear.app/comm/issue/ENG-2354/header-in-color-select-modal-barely-visible-on-dark-mode

Here's where I caused the regression: https://phab.comm.dev/D5619#171440

Basically I set color to modalForegroundLabel in a StyleSheet instead of in an unboundStyles object that gets "bound" with the useStyles(...) hook.

Thanks @kamil for catching this issue.

Test Plan:
Here's how it looks in light mode + dark mode:

Simulator Screen Shot - Alice - 2022-11-28 at 23.37.59.png (2×1 px, 165 KB)

Simulator Screen Shot - Alice - 2022-11-28 at 23.37.48.png (2×1 px, 167 KB)

Reviewers: kamil, tomek, marcin, ginsu, rohan, varun, ashoat

Reviewed By: ashoat

Subscribers: ashoat, kamil

Differential Revision: https://phab.comm.dev/D5751

Details

Provenance
atulAuthored on Nov 28 2022, 11:39 PM
Reviewer
ashoat
Differential Revision
D5751: [native] Fix issue with `ColorSelector` header color
Parents
rCOMM449de39cde50: [Nix] Add rabbitmq-up command
Branches
Unknown
Tags
Unknown