HomePhabricator
Diffusion Comm 3c57f0880e63

[lib] allow missing `messageIDs` while comparing SQLite with `redux-persist`

Tags
None
Referenced Files
F507891: image.png
Apr 26 2023, 6:07 AM
File Not Attached
Subscribers
None

Description

[lib] allow missing messageIDs while comparing SQLite with redux-persist

Summary:
This allows threadID that is present in database but not redux. This will help while debugging - instead of an error that cannot read messageIDs of undefined we will have a more readable message, having information on which keys are different. Is it an issue for one key and e.g. it was not removed from DB while needed or there is some issue and redux-persist state was purged.

Depends on D7611

Test Plan:
Make inconsistency and check if it is properly detected and logged

image.png (310×277 px, 57 KB)

Reviewers: tomek, marcin, michal

Reviewed By: tomek

Subscribers: ashoat, atul

Differential Revision: https://phab.comm.dev/D7612

Details

Provenance
kamilAuthored on Apr 25 2023, 6:22 AM
Reviewer
tomek
Differential Revision
D7612: [lib] allow missing `messageIDs` while comparing SQLite with `redux-persist`
Parents
rCOMM4c5309c02610: [lib] assert message store equality after logout
Branches
Unknown
Tags
Unknown