[lib] assert message store equality after logout
ClosedPublic
Actions

Authored by kamil on Apr 25 2023, 9:54 AM.

Details

Reviewers

tomek
marcin
michal

Commits

rCOMM4c5309c02610: [lib] assert message store equality after logout

Summary

Add missing check

Test Plan

Log out and check if there are no errors.

Verify that all other checks are available:

Go through all actions in the message reducer
Analyze which of them are modifying messageStore.threads
Confirm that ops are generated and state equality is checked

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 25 2023, 9:54 AM

kamil held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 25 2023, 9:54 AM

kamil added a child revision: D7612: [lib] allow missing `messageIDs` while comparing SQLite with `redux-persist`.Apr 25 2023, 10:04 AM

Harbormaster completed remote builds in B18743: Diff 25681.Apr 25 2023, 10:12 AM

kamil published this revision for review.Apr 25 2023, 10:32 AM

It is a good idea to check if there are other places where this check is missing. Describing how it was done should extend the test plan.

This revision is now accepted and ready to land.Apr 25 2023, 3:47 PM

kamil edited the test plan for this revision. (Show Details)Apr 26 2023, 6:02 AM

Closed by commit rCOMM4c5309c02610: [lib] assert message store equality after logout (authored by kamil). · Explain WhyApr 26 2023, 6:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM4c5309c02610: [lib] assert message store equality after logout.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

6 lines

Diff 25762

View Options

lib/reducers/message-reducer.js

[lib] assert message store equality after logoutClosedPublicActions