HomePhabricator
Diffusion Comm 40a81f92f599

[lib][native][web] Display a message when accepting an invite link times out

Tags
None
Referenced Files
F1667475: native_join_success.mov
Apr 29 2024, 2:20 AM
File Not Attached
F1667474: native_join_error.mov
Apr 29 2024, 2:20 AM
File Not Attached
F1667477: native_join_timeout.mov
Apr 29 2024, 2:20 AM
File Not Attached
F1667472: web_join_success.mov
Apr 29 2024, 2:20 AM
File Not Attached
F1667473: web_join_error.mov
Apr 29 2024, 2:20 AM
File Not Attached
F1667476: web_join_timeout.mov
Apr 29 2024, 2:20 AM
File Not Attached
Subscribers
None

Description

[lib][native][web] Display a message when accepting an invite link times out

Summary:
In order to support a timeout correctly on both platforms we had to change how we store the status on native.
Added a new status which represents a timeout and is handled in the same way as an invalid link - the only difference is a displayed message.

https://linear.app/comm/issue/ENG-7924/improve-invite-link-join-timeout-handling

Web timeout

Web invalid

Web success

Native timeout

Native invalid

Native success

Test Plan:
Tested on native and web:

  1. Added a timeout on the keyserver and checked if the timeout message appears
  2. Thrown an exception on the keyserver and checked if the invalid link message appears
  3. Checked if it is possible to join a community

Reviewers: inka, ashoat

Reviewed By: ashoat

Differential Revision: https://phab.comm.dev/D11812

Details

Provenance
tomekAuthored on Apr 25 2024, 8:05 AM
Reviewer
ashoat
Differential Revision
D11812: [lib][native][web] Display a message when accepting an invite link times out
Parents
rCOMMf9b0890966c4: [SQLite/lib] implement shared SQLite interface
Branches
Unknown
Tags
Unknown