Page MenuHomePhabricator

[lib][native][web] Display a message when accepting an invite link times out
ClosedPublic

Authored by tomek on Fri, Apr 26, 12:18 PM.
Tags
None
Referenced Files
F1713587: D11812.id.diff
Tue, May 7, 8:32 AM
Unknown Object (File)
Mon, May 6, 4:13 PM
Unknown Object (File)
Thu, May 2, 9:00 PM
Unknown Object (File)
Wed, May 1, 5:43 PM
Unknown Object (File)
Wed, May 1, 11:56 AM
Unknown Object (File)
Tue, Apr 30, 2:09 PM
F1667477: native_join_timeout.mov
Fri, Apr 26, 12:20 PM
F1667476: web_join_timeout.mov
Fri, Apr 26, 12:20 PM
Subscribers
None

Details

Summary

In order to support a timeout correctly on both platforms we had to change how we store the status on native.
Added a new status which represents a timeout and is handled in the same way as an invalid link - the only difference is a displayed message.

https://linear.app/comm/issue/ENG-7924/improve-invite-link-join-timeout-handling

Web timeout

Web invalid

Web success

Native timeout

Native invalid

Native success

Test Plan

Tested on native and web:

  1. Added a timeout on the keyserver and checked if the timeout message appears
  2. Thrown an exception on the keyserver and checked if the invalid link message appears
  3. Checked if it is possible to join a community

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable