Page MenuHomePhabricator
Differential D11823

[lib][native][web] Show a message when a user is already a part of a community
ClosedPublic
Actions

Authored by tomek on Fri, Apr 26, 1:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 11:56 AM
Unknown Object (File)
Sat, May 4, 9:36 AM
Unknown Object (File)
Thu, May 2, 8:41 PM
Unknown Object (File)
Tue, Apr 30, 3:38 PM
F1667914: already_a_member_native.png
Fri, Apr 26, 1:16 PM
F1667913: already_a_member_web.png
Fri, Apr 26, 1:16 PM
Subscribers
None

Details

Reviewers
inka
ashoat
Commits
rCOMMc3200b0b69aa: [lib][native][web] Show a message when a user is already a part of a community
Summary

Introduce a new status to the modals meaning that a user already joined a community.

https://linear.app/comm/issue/ENG-4391/display-a-message-if-youre-already-part-of-a-community

already_a_member_web.png (606×954 px, 45 KB)

already_a_member_native.png (905×439 px, 135 KB)

Depends on D11812

Test Plan

Checked on native and web:

  1. If accepting a link still works
  2. If a message is displayed when a user is already a part of a community

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Fri, Apr 26, 1:15 PM
tomek edited the summary of this revision. (Show Details)Fri, Apr 26, 1:16 PM
tomek added 1 blocking reviewer(s): ashoat.
Harbormaster completed remote builds in B28546: Diff 39602.Fri, Apr 26, 1:41 PM
tomek requested review of this revision.Fri, Apr 26, 1:41 PM
ashoat accepted this revision.Sat, Apr 27, 6:54 PM
ashoat added inline comments.
native/navigation/invite-link-modal.react.js
38–41 ↗(On Diff #39602)

Would this work and be more simple?

web/invite-links/accept-invite-modal.react.js
29–32 ↗(On Diff #39602)

Same here

This revision is now accepted and ready to land.Sat, Apr 27, 6:54 PM
tomek updated this revision to Diff 39621.Mon, Apr 29, 1:45 AM

Simplify

native/navigation/invite-link-modal.react.js
38–41 ↗(On Diff #39602)

Yes, makes sense!

Harbormaster completed remote builds in B28559: Diff 39621.Mon, Apr 29, 2:00 AM
Closed by commit rCOMMc3200b0b69aa: [lib][native][web] Show a message when a user is already a part of a community (authored by tomek). · Explain WhyMon, Apr 29, 2:21 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMc3200b0b69aa: [lib][native][web] Show a message when a user is already a part of a community.

Revision Contents
Changeset List

PathSize
lib/
hooks/
29 lines
native/
navigation/
3 lines
23 lines
web/
invite-links/
21 lines
3 lines

Diff 39630

View Options

lib/hooks/invite-links.js

Loading...
View Options

native/navigation/deep-links-context-provider.react.js

Loading...
View Options

native/navigation/invite-link-modal.react.js

Loading...
View Options

web/invite-links/accept-invite-modal.react.js

Loading...
View Options

web/invite-links/invite-link-handler.react.js

Loading...