HomePhabricator
Diffusion Comm 41dd2ebdbe6f

[lib] Ignore exceptions in extractUserIDsFromPayload

Description

[lib] Ignore exceptions in extractUserIDsFromPayload

Summary:
When an endpoint fails, it will respond with something that doesn't match the expected output validator.

This causes the client to throw a different error that the one we expect from the endpoint failing.

This diff addresses ENG-8324 by wrapping the convertObject call in a try-catch that ignores all exceptions.

Test Plan: I tested on both native and web by attempting to set an invite link corresponding to a reserved string. Before this diff I got a generic error, but afterwards I got the expected, more precise error

Reviewers: inka, varun, will, atul

Reviewed By: atul

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D12252

Details

Provenance
ashoatAuthored on May 30 2024, 12:18 PM
Reviewer
atul
Differential Revision
D12252: [lib] Ignore exceptions in extractUserIDsFromPayload
Parents
rCOMM8f250e7a9859: [lib] dispatch actions and populate aux user store with fids
Branches
Unknown
Tags
Unknown