Page MenuHomePhabricator

[lib] Ignore exceptions in extractUserIDsFromPayload
ClosedPublic

Authored by ashoat on May 30 2024, 12:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 6:19 AM
Unknown Object (File)
Mon, Mar 3, 6:18 AM
Unknown Object (File)
Fri, Feb 28, 3:02 PM
Unknown Object (File)
Fri, Feb 28, 3:02 PM
Unknown Object (File)
Jan 24 2025, 4:45 AM
Unknown Object (File)
Jan 24 2025, 4:45 AM
Unknown Object (File)
Jan 10 2025, 5:40 AM
Unknown Object (File)
Dec 31 2024, 12:51 PM
Subscribers

Details

Summary

When an endpoint fails, it will respond with something that doesn't match the expected output validator.

This causes the client to throw a different error that the one we expect from the endpoint failing.

This diff addresses ENG-8324 by wrapping the convertObject call in a try-catch that ignores all exceptions.

Test Plan

I tested on both native and web by attempting to set an invite link corresponding to a reserved string. Before this diff I got a generic error, but afterwards I got the expected, more precise error

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable