HomePhabricator
Diffusion Comm 442f3c83d404

[identity] Refactor types for inbound/outbound keys

Description

[identity] Refactor types for inbound/outbound keys

Summary:
Part of ENG-5842.
Previous approach to passing inbound/outbound keys was using HashMaps of strings to strings. Also, with new device list, we were serializing these to hashmaps, just to parse them back a few lines later.
This was error prone and hard to maintain, so this diff introduces new, simplified and type-safe structs for inbound/outbound keys.

Also, removed the logic for checking social proof existence for each device, which turned out to be incorrect. The social proof is still checked when creating the EthereumIdentity response struct.

Depends on D10700

Test Plan:

Reviewers: varun, will, michal

Reviewed By: varun

Subscribers: ashoat, tomek, will

Differential Revision: https://phab.comm.dev/D10701

Details

Provenance
bartekAuthored on Jan 18 2024, 3:51 AM
Reviewer
varun
Differential Revision
D10701: [identity] Refactor types for inbound/outbound keys
Parents
rCOMM3f4e7e9d81a9: [identity] Simplify some calls and conversions
Branches
Unknown
Tags
Unknown