Details
Details
- Reviewers
varun michal - Commits
- rCOMM3f4e7e9d81a9: [identity] Simplify some calls and conversions
Identity integration tests
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
services/identity/src/database.rs | ||
---|---|---|
258 ↗ | (On Diff #35783) | The add_password_user_device_to_users_table() and add_wallet_user_device_to_users_table() were duplicates with social_proof being the only difference |
592–598 ↗ | (On Diff #35783) | Unnecessary intermediate function |
924–936 ↗ | (On Diff #35783) |
I made a mistake here, there's a missing check which I accidentally committed in the next diff. I'll fix this when rebasing. if devices_response.is_empty() { debug!("No devices found for user {}", user_id); return Ok(None); } |
services/identity/src/database/device_list.rs | ||
---|---|---|
327 ↗ | (On Diff #35868) | at some point we should change PreKey to Prekey for consistency |