Page MenuHomePhabricator

[identity] Remove references to "devices" attr in users table
ClosedPublic

Authored by bartek on Jan 18 2024, 4:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 11:39 PM
Unknown Object (File)
Thu, Nov 7, 12:46 PM
Unknown Object (File)
Oct 18 2024, 3:43 AM
Unknown Object (File)
Oct 18 2024, 3:43 AM
Unknown Object (File)
Oct 18 2024, 3:43 AM
Unknown Object (File)
Oct 18 2024, 3:42 AM
Unknown Object (File)
Oct 18 2024, 3:42 AM
Unknown Object (File)
Oct 5 2024, 5:19 PM
Subscribers

Details

Summary

Part of ENG-5842.
This diff removes almost all code that referenced "devices" attribute in users table. The code left is not nice, further refactors are done in subsequent diffs.

The only part left is adding devices to the list, which is done separately in D10698 (I had to reverse diff order to make CI pass)

Test Plan

Identity integration tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.

Change diff order to make Commtest CI pass

bartek published this revision for review.Jan 18 2024, 8:07 AM
bartek added inline comments.
services/identity/src/database.rs
555–572 ↗(On Diff #35785)

This intermediate function is removed in the next diff

655–660 ↗(On Diff #35785)

This intermediate function is removed in the next diff

1155–1178 ↗(On Diff #35785)

Previously, we were merging legacy and new device list attribute by attribute, now we no longer need that.

This revision is now accepted and ready to land.Jan 18 2024, 2:09 PM