Page MenuHomePhabricator
Differential D10698

[identity] Stop adding devices to users table
ClosedPublic
Actions

Authored by bartek on Jan 18 2024, 3:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 1:17 AM
Unknown Object (File)
Sat, Mar 1, 5:01 AM
Unknown Object (File)
Thu, Feb 27, 10:30 AM
Unknown Object (File)
Tue, Feb 25, 9:55 AM
Unknown Object (File)
Feb 20 2025, 10:02 PM
Unknown Object (File)
Feb 11 2025, 1:39 PM
Unknown Object (File)
Feb 8 2025, 3:31 PM
Unknown Object (File)
Feb 6 2025, 11:47 PM
View All 93 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
michal
Commits
rCOMMb2737d97dc80: [identity] Stop adding devices to users table
Summary

Part of ENG-5842.

Removed code that adds devices to the users table. This is no longer needed since we add devices to the devices table now.

Test Plan
  • Identity integration tests
  • Manually registered a device and used awslocal dynamodb scan --table-name identity-users to verify that the device was not added to the users table.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jan 18 2024, 3:58 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 18 2024, 3:58 AM
bartek added a child revision: D10699: [identity] Remove references to "devices" attr in users table.Jan 18 2024, 4:00 AM
Harbormaster failed remote builds in B25886: Diff 35781!Jan 18 2024, 4:23 AM
bartek updated this revision to Diff 35786.Jan 18 2024, 5:10 AM

Change diff order to make Commtest CI pass

Harbormaster completed remote builds in B25891: Diff 35786.Jan 18 2024, 5:30 AM
bartek edited child revisions, added: D10700: [identity] Simplify some calls and conversions; removed: D10699: [identity] Remove references to "devices" attr in users table.Jan 18 2024, 5:33 AM
bartek added a parent revision: D10699: [identity] Remove references to "devices" attr in users table.
bartek mentioned this in D10699: [identity] Remove references to "devices" attr in users table.
bartek published this revision for review.Jan 18 2024, 8:07 AM
bartek added inline comments.
services/identity/src/database.rs
297–303 ↗(On Diff #35786)

Previously, this was called in add_device_to_users_table() which is now deleted

varun accepted this revision.Jan 18 2024, 2:10 PM
This revision is now accepted and ready to land.Jan 18 2024, 2:10 PM
Closed by commit rCOMMb2737d97dc80: [identity] Stop adding devices to users table (authored by bartek). · Explain WhyJan 22 2024, 6:49 AM
This revision was automatically updated to reflect the committed changes.
bartek mentioned this in rCOMMb8349ecd2e20: [identity] Remove references to "devices" attr in users table.
bartek added a commit: rCOMMb2737d97dc80: [identity] Stop adding devices to users table.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
1 line
189 lines

Diff 35966

View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Lines
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { import type {
UpdateConnectionStatusPayload, UpdateConnectionStatusPayload,
SetLateResponsePayload, SetLateResponsePayload,
UpdateKeyserverReachabilityPayload, UpdateKeyserverReachabilityPayload,
} from '../keyserver-conn/keyserver-conn-types.js'; } from '../keyserver-conn/keyserver-conn-types.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { AlertInfo } from '../types/alert-types.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
+threadStore: ThreadStore, +threadStore: ThreadStore,
+userStore: UserStore, +userStore: UserStore,
+messageStore: MessageStore, +messageStore: MessageStore,
+loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } }, +loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } },
+calendarFilters: $ReadOnlyArray<CalendarFilter>, +calendarFilters: $ReadOnlyArray<CalendarFilter>,
+notifPermissionAlertInfo: NotifPermissionAlertInfo, +notifPermissionAlertInfo: AlertInfo,
+watchedThreadIDs: $ReadOnlyArray<string>, +watchedThreadIDs: $ReadOnlyArray<string>,
+lifecycleState: LifecycleState, +lifecycleState: LifecycleState,
+enabledApps: EnabledApps, +enabledApps: EnabledApps,
+reportStore: ReportStore, +reportStore: ReportStore,
+dataLoaded: boolean, +dataLoaded: boolean,
+userPolicies: UserPolicies, +userPolicies: UserPolicies,
+commServicesAccessToken: ?string, +commServicesAccessToken: ?string,
+inviteLinksStore: InviteLinksStore, +inviteLinksStore: InviteLinksStore,
▲ Show 20 Lines • Show All 1,255 Lines • Show Last 20 Lines
View Options

services/identity/src/database.rs

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Lines
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { import type {
UpdateConnectionStatusPayload, UpdateConnectionStatusPayload,
SetLateResponsePayload, SetLateResponsePayload,
UpdateKeyserverReachabilityPayload, UpdateKeyserverReachabilityPayload,
} from '../keyserver-conn/keyserver-conn-types.js'; } from '../keyserver-conn/keyserver-conn-types.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { AlertInfo } from '../types/alert-types.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
+threadStore: ThreadStore, +threadStore: ThreadStore,
+userStore: UserStore, +userStore: UserStore,
+messageStore: MessageStore, +messageStore: MessageStore,
+loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } }, +loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } },
+calendarFilters: $ReadOnlyArray<CalendarFilter>, +calendarFilters: $ReadOnlyArray<CalendarFilter>,
+notifPermissionAlertInfo: NotifPermissionAlertInfo, +notifPermissionAlertInfo: AlertInfo,
+watchedThreadIDs: $ReadOnlyArray<string>, +watchedThreadIDs: $ReadOnlyArray<string>,
+lifecycleState: LifecycleState, +lifecycleState: LifecycleState,
+enabledApps: EnabledApps, +enabledApps: EnabledApps,
+reportStore: ReportStore, +reportStore: ReportStore,
+dataLoaded: boolean, +dataLoaded: boolean,
+userPolicies: UserPolicies, +userPolicies: UserPolicies,
+commServicesAccessToken: ?string, +commServicesAccessToken: ?string,
+inviteLinksStore: InviteLinksStore, +inviteLinksStore: InviteLinksStore,
▲ Show 20 Lines • Show All 1,255 Lines • Show Last 20 Lines