[identity] Rename PreKey DB struct to Prekey
ClosedPublic
Actions

Authored by bartek on Jan 23 2024, 5:29 AM.

Details

Reviewers

varun
michal

Commits

rCOMM348022e9af0b: [identity] Rename PreKey DB struct to Prekey

Summary

Addressed comment from https://phab.comm.dev/D10700#inline-65456

Depends on D10765

Test Plan

Cargo build

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 23 2024, 5:29 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 23 2024, 5:29 AM

bartek mentioned this in D10700: [identity] Simplify some calls and conversions.Jan 23 2024, 5:30 AM

Harbormaster completed remote builds in B26077: Diff 36032.Jan 23 2024, 6:11 AM

bartek published this revision for review.Jan 23 2024, 7:14 AM

varun accepted this revision.Jan 23 2024, 8:18 PM

This revision is now accepted and ready to land.Jan 23 2024, 8:18 PM

just one thing that needs to be changed

services/identity/src/database/device_list.rs
329–333 ↗	(On Diff #36032)

Address comment

Harbormaster completed remote builds in B26117: Diff 36088.Jan 23 2024, 10:06 PM

Closed by commit rCOMM348022e9af0b: [identity] Rename PreKey DB struct to Prekey (authored by bartek). · Explain WhyJan 26 2024, 8:33 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM348022e9af0b: [identity] Rename PreKey DB struct to Prekey.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

6 lines

database/

device_list.rs

74 lines

Diff 36181

View Options

services/identity/src/database.rs