HomePhabricator
Diffusion Comm 4eabcb008b16

[keyserver] Use blank target in invite link

Tags
None
Referenced Files
F630050: link-baner.png
Jul 11 2023, 7:27 AM
File Not Attached
F630049: link-alert.png
Jul 11 2023, 7:27 AM
File Not Attached
Subscribers
None

Description

[keyserver] Use blank target in invite link

Summary:
This page is displayed only on iOS devices. For Safari, this changes invite links experience a bit - the browser shows an alert

link-alert.png (2×1 px, 287 KB)

asking if a page should be opened instead of showing a banner.

link-baner.png (2×1 px, 303 KB)

It is also possible that this diff could solve an issue on other browsers https://linear.app/comm/issue/ENG-4089/invite-links-dont-work-on-prod#comment-2e1dff05.

Also included a small change where inviteLinkUrl is used instead of hardcoded URL.

Test Plan: Open a link and check if the app is opened (both on Safari and Chrome).

Reviewers: kamil, inka, bartek

Reviewed By: kamil

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D8465

Details

Provenance
tomekAuthored on Jul 10 2023, 7:11 AM
Reviewer
kamil
Differential Revision
D8465: [keyserver] Use blank target in invite link
Parents
rCOMM43fb444900bb: [lib][keyserver] Use blobURI based on client version
Branches
Unknown
Tags
Unknown