[keyserver] Use blank target in invite link
ClosedPublic
Actions

Authored by tomek on Jul 10 2023, 7:13 AM.

Details

Reviewers

kamil
inka
bartek

Commits

rCOMM4eabcb008b16: [keyserver] Use blank target in invite link

Summary

This page is displayed only on iOS devices. For Safari, this changes invite links experience a bit - the browser shows an alert

asking if a page should be opened instead of showing a banner.

It is also possible that this diff could solve an issue on other browsers https://linear.app/comm/issue/ENG-4089/invite-links-dont-work-on-prod#comment-2e1dff05.

Also included a small change where inviteLinkUrl is used instead of hardcoded URL.

Test Plan

Open a link and check if the app is opened (both on Safari and Chrome).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jul 10 2023, 7:13 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 10 2023, 7:13 AM

tomek edited the summary of this revision. (Show Details)Jul 10 2023, 7:14 AM

Harbormaster completed remote builds in B20847: Diff 28552.Jul 10 2023, 7:30 AM

tomek requested review of this revision.Jul 10 2023, 7:30 AM

kamil accepted this revision.Jul 11 2023, 1:46 AM

This revision is now accepted and ready to land.Jul 11 2023, 1:46 AM

Closed by commit rCOMM4eabcb008b16: [keyserver] Use blank target in invite link (authored by tomek). · Explain WhyJul 11 2023, 7:27 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM4eabcb008b16: [keyserver] Use blank target in invite link.

kamil mentioned this in D8486: [keyserver] Remove target blank.Jul 12 2023, 7:35 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

website-responders.js

4 lines

Diff 28587

View Options

keyserver/src/responders/website-responders.js

[keyserver] Use blank target in invite linkClosedPublicActions