HomePhabricator
Diffusion Comm 54348ade8842

[Services] Use BUILD_TESTING for tunnelbroker build

Description

[Services] Use BUILD_TESTING for tunnelbroker build

Summary:
The biggest change is building the testsuite by default, however, this is
the common practice, and generally people opt-out of building tests by doing
-DBUILD_TESTING=OFF when they invoke cmake.

https://linear.app/comm/issue/ENG-1794

Test Plan:

nix develop
cd services/tunnelbroker
rm -rf build && mkdir build && cd build && cmake .. && make -j
ctest # should fail as AWS needs to be configured, but run

# without tests
nix develop
cd services/tunnelbroker
rm -rf build && mkdir build && cd build && cmake .. -DBUILD_TESTING=OFF && make -j
ctest # should fail to find tests

Reviewers: atul, abosh, varun, max, karol

Reviewed By: atul

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D5118

Details

Provenance
jonAuthored on Sep 12 2022, 1:23 PM
Reviewer
atul
Differential Revision
D5118: [Services] Use BUILD_TESTING for tunnelbroker build
Parents
rCOMMf3f886ab6d54: [Services] Fix backup test suite build
Branches
Unknown
Tags
Unknown