[Services] Use BUILD_TESTING for tunnelbroker build
ClosedPublic
Actions

Authored by • jon on Sep 12 2022, 1:47 PM.

Details

Reviewers

atul
• abosh
varun
• max
• karol

Commits

rCOMM54348ade8842: [Services] Use BUILD_TESTING for tunnelbroker build

Summary

The biggest change is building the testsuite by default, however, this is
the common practice, and generally people opt-out of building tests by doing
-DBUILD_TESTING=OFF when they invoke cmake.

https://linear.app/comm/issue/ENG-1794

Test Plan

nix develop
cd services/tunnelbroker
rm -rf build && mkdir build && cd build && cmake .. && make -j
ctest # should fail as AWS needs to be configured, but run

# without tests
nix develop
cd services/tunnelbroker
rm -rf build && mkdir build && cd build && cmake .. -DBUILD_TESTING=OFF && make -j
ctest # should fail to find tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Sep 12 2022, 1:47 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2022, 1:47 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2022, 1:48 PM

Harbormaster failed remote builds in B12093: Diff 16600!

• jon added a parent revision: D5121: [Services] Avoid using GTest in docker.Sep 12 2022, 2:03 PM

• jon added a child revision: D5119: [Chore] Cleanup tunnelbroker CMakeLists.txt.

Rebase on top of docker fixes

Harbormaster completed remote builds in B12100: Diff 16607.Sep 12 2022, 2:16 PM

• jon requested review of this revision.Sep 12 2022, 2:16 PM

In this case:

nix develop
cd services/tunnelbroker
rm -rf build && mkdir build && cd build && cmake .. && make -j
ctest # should fail as AWS needs to be configured, but run

the tests aren't running (and failing). Instead, I'm getting the following (which I'd expect to get--and do--with -DBUILD_TESTING=OFF):