Page MenuHomePhabricator
Differential D5119

[Chore] Cleanup tunnelbroker CMakeLists.txt
ClosedPublic
Actions

Authored by • jon on Sep 12 2022, 1:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 1:07 AM
Unknown Object (File)
Thu, Mar 20, 9:44 PM
Unknown Object (File)
Tue, Mar 18, 8:40 AM
Unknown Object (File)
Tue, Mar 18, 1:45 AM
Unknown Object (File)
Tue, Mar 18, 1:45 AM
Unknown Object (File)
Mon, Mar 17, 4:11 AM
Unknown Object (File)
Mon, Mar 17, 4:11 AM
Unknown Object (File)
Sun, Mar 16, 6:12 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
varun
• abosh
• max
• karol
Commits
rCOMM237416184fb3: [Chore] Cleanup tunnelbroker CMakeLists.txt
Summary

Noticed some dead code from D4671

Test Plan

tunnelbroker CI passes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Sep 12 2022, 1:50 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2022, 1:50 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2022, 1:51 PM
Harbormaster failed remote builds in B12094: Diff 16601!
• jon added a parent revision: D5118: [Services] Use BUILD_TESTING for tunnelbroker build.Sep 12 2022, 2:03 PM
• jon updated this revision to Diff 16608.Sep 12 2022, 2:06 PM

Rebase on top of docker fixes

• jon updated this revision to Diff 16611.Sep 12 2022, 2:09 PM

Rebase

Harbormaster completed remote builds in B12101: Diff 16608.Sep 12 2022, 2:16 PM
Harbormaster completed remote builds in B12104: Diff 16611.Sep 12 2022, 2:19 PM
• jon requested review of this revision.Sep 12 2022, 2:19 PM
atul accepted this revision.Sep 13 2022, 9:34 AM

In addition to tunnelbroker CI, was able to run docker-compose build --no-cache tunnelbroker-server successfully on Apple silicon

This revision is now accepted and ready to land.Sep 13 2022, 9:34 AM
Closed by commit rCOMM237416184fb3: [Chore] Cleanup tunnelbroker CMakeLists.txt (authored by • jon). · Explain WhySep 13 2022, 11:45 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM237416184fb3: [Chore] Cleanup tunnelbroker CMakeLists.txt.
ashoat added inline comments.Sep 15 2022, 7:04 PM
services/tunnelbroker/CMakeLists.txt
77–81

I'm a bit confused, what's the point of this line now?

• jon added inline comments.Sep 15 2022, 7:06 PM
services/tunnelbroker/CMakeLists.txt
77–81

Good point, guess this isn't needed either.

ashoat added inline comments.Sep 16 2022, 8:03 AM
services/tunnelbroker/CMakeLists.txt
77–81

D5160

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
5 lines

Diff 16632

View Options

services/tunnelbroker/CMakeLists.txt

#pragma once #pragma once
#include "AwsTools.h" #include "AwsTools.h"
#include "Constants.h" #include "Constants.h"
#include "DatabaseEntitiesTools.h" #include "DatabaseEntitiesTools.h"
#include "Tools.h" #include "Tools.h"
#include <aws/core/Aws.h> #include <aws/core/Aws.h>
#include <aws/core/utils/Outcome.h> #include <aws/core/utils/Outcome.h>
#include <aws/dynamodb/model/AttributeDefinition.h> #include <aws/dynamodb/model/AttributeDefinition.h>
#include <aws/dynamodb/model/DeleteItemRequest.h> #include <aws/dynamodb/model/DeleteItemRequest.h>
#include <aws/dynamodb/model/DescribeTableRequest.h> #include <aws/dynamodb/model/DescribeTableRequest.h>
#include <aws/dynamodb/model/DescribeTableResult.h> #include <aws/dynamodb/model/DescribeTableResult.h>
#include <aws/dynamodb/model/GetItemRequest.h> #include <aws/dynamodb/model/GetItemRequest.h>
#include <aws/dynamodb/model/PutItemRequest.h> #include <aws/dynamodb/model/PutItemRequest.h>
#include <aws/dynamodb/model/QueryRequest.h>
#include <memory> #include <memory>
#include <string> #include <string>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
Show All 22 Linespublic:
void removeSessionSignItem(const std::string &deviceID); void removeSessionSignItem(const std::string &deviceID);
void putPublicKeyItem(const PublicKeyItem &item); void putPublicKeyItem(const PublicKeyItem &item);
std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID); std::shared_ptr<PublicKeyItem> findPublicKeyItem(const std::string &deviceID);
void removePublicKeyItem(const std::string &deviceID); void removePublicKeyItem(const std::string &deviceID);
void putMessageItem(const MessageItem &item); void putMessageItem(const MessageItem &item);
std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID); std::shared_ptr<MessageItem> findMessageItem(const std::string &messageID);
std::vector<std::shared_ptr<MessageItem>>
findMessageItemsByReceiver(const std::string &toDeviceID);
void removeMessageItem(const std::string &messageID); void removeMessageItem(const std::string &messageID);
}; };
} // namespace database } // namespace database
} // namespace network } // namespace network
} // namespace comm } // namespace comm