Page MenuHomePhabricator

[services] Remove no-op variable assignment in Tunnelbroker CMakeLists.txt
ClosedPublic

Authored by ashoat on Sep 16 2022, 8:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 1:46 PM
Unknown Object (File)
Sun, Oct 27, 4:32 AM
Unknown Object (File)
Tue, Oct 15, 9:23 AM
Unknown Object (File)
Wed, Oct 9, 8:41 PM
Unknown Object (File)
Tue, Oct 8, 8:20 AM
Unknown Object (File)
Tue, Oct 8, 1:18 AM
Unknown Object (File)
Thu, Oct 3, 2:00 AM
Unknown Object (File)
Sep 30 2024, 3:40 PM

Details

Summary

Context here

Test Plan

I actually haven't tested this. Hoping CI will handle it... the change seems reasonable

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 16 2022, 8:05 AM
Harbormaster failed remote builds in B12217: Diff 16758!

Not sure what the Tunnelbroker CI failures are about... @jon, @max – any context?

Not sure what the Tunnelbroker CI failures are about... @jon, @max – any context?

That issue is being tracked https://linear.app/comm/issue/ENG-1836/investigate-protobuf-failures-in-nix-ci

Essentially one of the builders has a tainted environment which I can't reproduce on my local intel mac

This revision is now accepted and ready to land.Sep 16 2022, 11:47 AM