Differential D5160

[services] Remove no-op variable assignment in Tunnelbroker CMakeLists.txt
ClosedPublic
Actions

Authored by ashoat on Sep 16 2022, 8:03 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 18, 8:52 PM

	Unknown Object (File)
	Mon, Mar 17, 4:18 AM

	Unknown Object (File)
	Mon, Mar 17, 4:18 AM

	Unknown Object (File)
	Sun, Mar 16, 6:12 PM

	Unknown Object (File)
	Tue, Mar 11, 10:44 AM

	Unknown Object (File)
	Tue, Mar 4, 2:00 PM

	Unknown Object (File)
	Tue, Mar 4, 2:00 PM

	Unknown Object (File)
	Tue, Mar 4, 2:00 PM

Subscribers

Details

Reviewers

Commits

rCOMMe69bf8d64369: [services] Remove no-op variable assignment in Tunnelbroker CMakeLists.txt

Summary

Context here

Test Plan

I actually haven't tested this. Hoping CI will handle it... the change seems reasonable

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 16 2022, 8:03 AM

Herald added subscribers: • abosh, • karol, atul, tomek. · View Herald TranscriptSep 16 2022, 8:03 AM

ashoat mentioned this in D5119: [Chore] Cleanup tunnelbroker CMakeLists.txt.Sep 16 2022, 8:03 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 16 2022, 8:05 AM

Harbormaster failed remote builds in B12217: Diff 16758!

Not sure what the Tunnelbroker CI failures are about... @jon, @max – any context?

ashoat requested review of this revision.Sep 16 2022, 10:52 AM

Harbormaster completed remote builds in B12217: Diff 16758.Sep 16 2022, 10:54 AM

Ah nice it's all green now

Not sure what the Tunnelbroker CI failures are about... @jon, @max – any context?

That issue is being tracked https://linear.app/comm/issue/ENG-1836/investigate-protobuf-failures-in-nix-ci

Essentially one of the builders has a tainted environment which I can't reproduce on my local intel mac

LGTM, thanks :)

This revision is now accepted and ready to land.Sep 16 2022, 11:47 AM

Closed by commit rCOMMe69bf8d64369: [services] Remove no-op variable assignment in Tunnelbroker CMakeLists.txt (authored by ashoat). · Explain WhySep 16 2022, 12:09 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe69bf8d64369: [services] Remove no-op variable assignment in Tunnelbroker CMakeLists.txt.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

6 lines

Diff 16777

services/tunnelbroker/CMakeLists.txt

	Show First 20 Lines • Show All 326 Lines • ▼ Show 20 Lines		if (Platform.OS === 'ios') {
	await this.ensureAndroidPushNotifsEnabled();			await this.ensureAndroidPushNotifsEnabled();
	}			}
	}			}

	async ensureAndroidPushNotifsEnabled() {			async ensureAndroidPushNotifsEnabled() {
	const firebase = getFirebase();			const firebase = getFirebase();
	const hasPermission = await firebase.messaging().hasPermission();			const hasPermission = await firebase.messaging().hasPermission();
	if (!hasPermission) {			if (!hasPermission) {
	try {
	await firebase.messaging().requestPermission();
	} catch {
	this.failedToRegisterPushPermissions();			this.failedToRegisterPushPermissions();
	return;			return;
	}			}
	}

	const fcmToken = await firebase.messaging().getToken();			const fcmToken = await firebase.messaging().getToken();
	if (fcmToken) {			if (fcmToken) {
	await this.handleAndroidDeviceToken(fcmToken);			await this.handleAndroidDeviceToken(fcmToken);
	} else {			} else {
	this.failedToRegisterPushPermissions();			this.failedToRegisterPushPermissions();
	}			}
	}			}
	▲ Show 20 Lines • Show All 278 Lines • Show Last 20 Lines