[lib] Propagate exceptions in keyserverAuth to callers
Summary:
I had made this change initially in D11500, but I forget why so I undid it.
The reason for the change is that dispatchActionPromise will not reject if the promise passed to it rejects.
We want failures in keyserverAuth to propagate to callers. At all of its callsites, keyserverAuth calls are wrapped in a try-catch where we need to do something on failure:
Test Plan:
- Force keyserver auth to fail with this patch
- Make sure LOG_OUT_STARTED and LOG_OUT_SUCCESS are dispatched when keyserver auth fails
Reviewers: tomek, inka
Reviewed By: tomek
Differential Revision: https://phab.comm.dev/D11837