This diff is gated on usingCommServicesAccessToken. We fall back to legacy keyserver auth if the new identity-based workflow doesn't work.
Depends on D11499
Details
Details
Tested in combination with later diffs:
- Set up multi-keyserver environment following Notion doc
- Test native keyserver recovery via keyserverAuth by deleting a cookie in MariaDB console
- Hardcode incorrect userID, try same test as 2, and confirm that it fails
- Test web keyserver recovery in the same way as in 2
- Test incorrect userID on web in the same way as in 3
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/components/keyserver-connection-handler.js | ||
|---|---|---|
| 169–170 | Is there a reason to change the awaiting approach? | |
| lib/components/keyserver-connection-handler.js | ||
|---|---|---|
| 169–170 | To be honest, I'm not sure. I wrote this code months ago, but it took a while to test it and feel confident putting the diffs up. Looking at the redux-thunk docs, it seems like either approach should work. Before landing, I'll do some testing and see if we can keep the previous approach. | |