HomePhabricator
Diffusion Comm 63c7412fe68b

[native] Introduce RegistrationButtonContainer

Description

[native] Introduce RegistrationButtonContainer

Summary:
What we really want is the gap style introduced in React Native 0.71.

To make it so we have a consistent 16px above, between, and below buttons, my approach in this diff is:

  1. Add a RegistrationButtonContainer that always applies an 8px margin above and below buttons.
  2. Make all RegistrationButtons apply an additional 8px margin above and below themselves.

Depends on D7831

Test Plan:
With an artificially tall ConnectEthereum screen:

beforeafter
Screenshot 2023-05-16 at 7.18.21 AM.png (2×1 px, 977 KB)
Screenshot 2023-05-16 at 7.15.39 AM.png (2×1 px, 979 KB)

Other screens (which only have one button) are unchanged.

Reviewers: ginsu, atul

Reviewed By: ginsu

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D7832

Details

Provenance
ashoatAuthored on May 16 2023, 4:16 AM
Reviewer
ginsu
Differential Revision
D7832: [native] Introduce RegistrationButtonContainer
Parents
rCOMMdd8352994644: [native] Remove useStyles call from RegistrationContentContainer
Branches
Unknown
Tags
Unknown