Page MenuHomePhabricator

[native] Introduce RegistrationButtonContainer
ClosedPublic

Authored by ashoat on May 16 2023, 4:19 AM.
Tags
None
Referenced Files
F3239749: D7832.diff
Wed, Nov 13, 10:38 AM
Unknown Object (File)
Fri, Nov 1, 6:07 PM
Unknown Object (File)
Fri, Nov 1, 6:07 PM
Unknown Object (File)
Fri, Nov 1, 6:07 PM
Unknown Object (File)
Fri, Nov 1, 6:01 PM
Unknown Object (File)
Wed, Oct 23, 3:23 AM
Unknown Object (File)
Oct 2 2024, 3:00 PM
Unknown Object (File)
Sep 17 2024, 11:33 PM
Subscribers

Details

Summary

What we really want is the gap style introduced in React Native 0.71.

To make it so we have a consistent 16px above, between, and below buttons, my approach in this diff is:

  1. Add a RegistrationButtonContainer that always applies an 8px margin above and below buttons.
  2. Make all RegistrationButtons apply an additional 8px margin above and below themselves.

Depends on D7831

Test Plan

With an artificially tall ConnectEthereum screen:

beforeafter
Screenshot 2023-05-16 at 7.18.21 AM.png (2×1 px, 977 KB)
Screenshot 2023-05-16 at 7.15.39 AM.png (2×1 px, 979 KB)

Other screens (which only have one button) are unchanged.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable