HomePhabricator
Diffusion Comm 710d0806cf28

[lib] Introduce member_ prefix for permission strings

Description

[lib] Introduce member_ prefix for permission strings

Summary: This diff introduces the types for this new prefix, and updates parseThreadPermissionString to be able to parse it.

Test Plan:
The whole stack was tested as follows:

  1. Unit tests from D9686, which toggle user-surfaced permissions on and off and make sure no difference is caught. This ensures that the original issue introduced in D9686 isn't reintroduced
  2. Careful review of each descendant permission removed in D9686
  3. Create a community as userA and add userB. Grant tagging permissions to all members. Make sure userB can tag inside non-root channels
  4. Do above, then create a channel without userB, and make sure userB can't tag there either (or do anything other than view). This is the repro described here
  5. Do above, but also create a thread inside the channel (as userA) and make sure userB can't do anything inside the thread other than view, until they join the parent channel

Reviewers: tomek, inka

Reviewed By: tomek

Differential Revision: https://phab.comm.dev/D13013

Details

Provenance
ashoatAuthored on Aug 7 2024, 11:24 AM
Reviewer
tomek
Differential Revision
D13013: [lib] Introduce member_ prefix for permission strings
Parents
rCOMMf9c63706bbd2: [lib] Extract read status operations logic
Branches
Unknown
Tags
Unknown