Page MenuHomePhabricator

[lib] Introduce member_ prefix for permission strings
ClosedPublic

Authored by ashoat on Aug 7 2024, 1:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 6:01 AM
Unknown Object (File)
Sun, Nov 3, 5:42 AM
Unknown Object (File)
Mon, Oct 14, 7:41 PM
Unknown Object (File)
Mon, Oct 14, 7:41 PM
Unknown Object (File)
Mon, Oct 14, 7:41 PM
Unknown Object (File)
Mon, Oct 14, 7:41 PM
Unknown Object (File)
Sep 10 2024, 12:06 AM
Unknown Object (File)
Sep 9 2024, 7:22 PM
Subscribers
None

Details

Summary

This diff introduces the types for this new prefix, and updates parseThreadPermissionString to be able to parse it.

Test Plan

The whole stack was tested as follows:

  1. Unit tests from D9686, which toggle user-surfaced permissions on and off and make sure no difference is caught. This ensures that the original issue introduced in D9686 isn't reintroduced
  2. Careful review of each descendant permission removed in D9686
  3. Create a community as userA and add userB. Grant tagging permissions to all members. Make sure userB can tag inside non-root channels
  4. Do above, then create a channel without userB, and make sure userB can't tag there either (or do anything other than view). This is the repro described here
  5. Do above, but also create a thread inside the channel (as userA) and make sure userB can't do anything inside the thread other than view, until they join the parent channel

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 7 2024, 1:37 PM
Harbormaster failed remote builds in B30985: Diff 43228!
ashoat requested review of this revision.Aug 7 2024, 1:38 PM
This revision is now accepted and ready to land.Aug 8 2024, 2:59 AM
This revision was landed with ongoing or failed builds.Aug 9 2024, 7:28 PM
This revision was automatically updated to reflect the committed changes.