HomePhabricator
Diffusion Comm 73b3c7af4d50

[web] Avoid changing height when error occurs in log in screen

Description

[web] Avoid changing height when error occurs in log in screen

Summary:
This diff hardcodes the error to have height: 0, and increases the margin around OrBreak to make up for that. I don't love that asymmetry of this solution when displaying the error, but the extra spacing doesn't look too bad.

OrBreak is used in one other place (SIWELogInForm), so I included a screenshot of that screen in the Test Plan.

Depends on D12086

Test Plan:

Screenshot 2024-05-16 at 7.42.06 PM.png (1×852 px, 133 KB)

Reviewers: ginsu

Reviewed By: ginsu

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D12087

Details

Provenance
ashoatAuthored on May 16 2024, 4:43 PM
Reviewer
ginsu
Differential Revision
D12087: [web] Avoid changing height when error occurs in log in screen
Parents
rCOMM6bc74c111e23: [web] Keep sign in button the same size when loading
Branches
Unknown
Tags
Unknown