Page MenuHomePhabricator

[web] Keep sign in button the same size when loading
ClosedPublic

Authored by ashoat on May 16 2024, 5:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 6:11 AM
Unknown Object (File)
Sun, Nov 24, 1:51 PM
Unknown Object (File)
Wed, Nov 13, 8:53 PM
Unknown Object (File)
Sat, Nov 9, 2:01 PM
Unknown Object (File)
Sat, Nov 9, 1:00 PM
Unknown Object (File)
Sat, Nov 9, 8:48 AM
Unknown Object (File)
Fri, Nov 8, 3:21 AM
Unknown Object (File)
Sat, Nov 2, 7:45 AM
Subscribers

Details

Summary

Noticed that the button shifted in height when loading. Prior to this diff, the button was increasing in height when loading, due to an explicit min-height property that gets set when it is disabled. It looks like this was built by an intern several years ago, and the min-height was probably added to make sure the button height didn't go to 0 or some small number.

This diff changes it so the height is based on the text, and the spinner is absolutely-positioned over the text. To keep the height the same even when the text is hidden, we use visibility: hidden for the text instead of display: none.

Depends on D12085

Test Plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable