[native] Handle client version unsupported errors in registrationServerCall
ClosedPublic
Actions

Authored by ashoat on May 16 2024, 5:05 PM.

Details

Reviewers

inka

Commits

rCOMM1733abed8e0b: [native] Handle client version unsupported errors in registrationServerCall

Summary

We were handling these in some places, but not all. This diff makes sure we handle it all places in registrationServerCall, which gets us closer to resolving ENG-8113.

Depends on D12084

Test Plan

There are a lot of spots here, and I didn't check all of them. I verified the core parts:

That identity service returns Unsupported version and keyserver returns client_version_unsupported when the client version is outdated
That the Alerts showed correctly
That onAlertAcknowledged worked

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 16 2024, 5:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 16 2024, 5:05 PM

ashoat added a child revision: D12086: [web] Keep sign in button the same size when loading.May 16 2024, 5:06 PM

Harbormaster returned this revision to the author for changes because remote builds failed.May 16 2024, 5:10 PM

Harbormaster failed remote builds in B29000: Diff 40309!

Harbormaster completed remote builds in B29000: Diff 40309.May 16 2024, 5:25 PM

ashoat requested review of this revision.May 16 2024, 5:25 PM

inka accepted this revision.May 17 2024, 3:57 AM

inka added inline comments.

native/account/registration/registration-server-call.js
264–285 ↗	(On Diff #40309)	This makes it confusing to read, because we don't handle the errors in the above cases in this `else/if` block. I would rather this code was more consistent, and this error handling was refactored to a separate function like for `identityRegisterUsernameAccount` and `legacyKeyserverRegisterUsernameAccount`. And the same for `identityWalletRegisterCall`. Can we do that?