Page MenuHomePhabricator

[native] Use getMessageForException in registrationServerCall
ClosedPublic

Authored by ashoat on May 16 2024, 5:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 25, 3:55 AM
Unknown Object (File)
Sun, Jun 23, 9:11 PM
Unknown Object (File)
Sun, Jun 23, 4:17 AM
Unknown Object (File)
Sun, Jun 23, 4:17 AM
Unknown Object (File)
Fri, Jun 21, 2:42 AM
Unknown Object (File)
Wed, Jun 19, 4:06 PM
Unknown Object (File)
Wed, Jun 19, 9:11 AM
Unknown Object (File)
Sat, Jun 15, 1:52 AM
Subscribers

Details

Summary

Noticed a couple places where we were accessing e.message directly, which can be dangerous if a primitive is thrown.

Depends on D12083

Test Plan

I didn't test this beyond how I tested the rest of the stack. Based on my familiarity with this code, it should be a safe change

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable