Page MenuHomePhabricator
Differential D12083

[native] Call goBackToPrompt when registration fails in FullscreenSIWEPanel
ClosedPublic
Actions

Authored by ashoat on May 16 2024, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 25, 6:22 AM
Unknown Object (File)
Sun, Jun 23, 9:05 AM
Unknown Object (File)
Sun, Jun 23, 5:45 AM
Unknown Object (File)
Sun, Jun 23, 4:17 AM
Unknown Object (File)
Sun, Jun 23, 4:17 AM
Unknown Object (File)
Fri, Jun 21, 9:20 AM
Unknown Object (File)
Wed, Jun 19, 4:06 PM
Unknown Object (File)
Wed, Jun 19, 9:11 AM
View All 23 Files
Subscribers
tomek

Details

Reviewers
inka
Commits
rCOMMe4cb78135622: [native] Call goBackToPrompt when registration fails in FullscreenSIWEPanel
Summary

When something goes wrong during registration, we always show an Alert in registrationServerCall.

When registrationServerCall is called from FullscreenSIWEPanel, we want to call goBackToPrompt if it fails, after the user acknowledges the prompt.

Depends on D12082

Test Plan
  1. Force a client_version_unsupported failure by hardcoding it in keyserver/src/session/version.js
  2. Disable enableNewRegistrationMode
  3. Enable usingCommServicesAccessToken
  4. Try FullscreenSIWEPanel with a wallet that hasn't been registered before
  5. Verify that goBackToPrompt is called after acknowledging the Alert

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
account/
1 line
registration/
32 lines
1 line

Diff 40326

View Options

native/account/fullscreen-siwe-panel.react.js

Loading...
View Options

native/account/registration/registration-server-call.js

Loading...
View Options

native/account/registration/registration-types.js

Loading...