HomePhabricator
Diffusion Comm 741d13e16233

[web] fix prop drilling within relationships modals

Description

[web] fix prop drilling within relationships modals

Summary:
PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

As I was working with the relationship modals/panels I found that we were drilling this onClose prop method that pretty much was just popModal. We don't need to drill this down everywhere and instead we can just call popModal using useModalContext hook where we need it.

Depends on D10742

Test Plan: flow + confirmed that the modal on close behavoir was popping as expected

Reviewers: atul, inka

Reviewed By: atul

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10743

Details

Provenance
ginsuAuthored on Jan 10 2024, 8:54 PM
Reviewer
atul
Differential Revision
D10743: [web] fix prop drilling within relationships modals
Parents
rCOMMc406518a2083: [web] fix add users list modal functionality
Branches
Unknown
Tags
Unknown