Page MenuHomePhabricator

[web] fix add users list modal functionality
ClosedPublic

Authored by ginsu on Jan 19 2024, 8:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 7:59 PM
Unknown Object (File)
Apr 8 2024, 4:32 PM
Unknown Object (File)
Apr 8 2024, 4:32 PM
Unknown Object (File)
Apr 8 2024, 4:32 PM
Unknown Object (File)
Apr 8 2024, 4:32 PM
Unknown Object (File)
Apr 8 2024, 4:32 PM
Unknown Object (File)
Apr 8 2024, 5:24 AM
Unknown Object (File)
Mar 27 2024, 6:53 AM
Subscribers

Details

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

In D10719 I had to lift the logic for the send friend requests button to the AddUsersListModal component. To make things easier to review, I lifted part of the logic and created a few TODOs for me to circle back to (specifically with the logic for the pending users since that was going to have significant changes with the new checkbox ux)

This diff lifts the pendingUsersToAdd set to the AddUsersListModal component, and with pendingUsersToAdd now in AddUsersListModal I can fix up all the TODOs I set in D10719, and all the functionality should be working again

Linear task: https://linear.app/comm/issue/ENG-5957/update-the-ui-of-add-friends-modal

Depends on D10735

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Jan 19 2024, 8:53 AM
This revision is now accepted and ready to land.Jan 22 2024, 9:38 AM
ginsu edited the summary of this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Feb 15 2024, 1:18 AM
This revision was automatically updated to reflect the committed changes.