Differential D10282 Authored by ginsu on Dec 8 2023, 1:55 PM.
Details Summary As I was working to visaully cleanup the thread notifications modal, I found the rendering logic for this modal pretty confusing/hard to read. Broke down the different parts of this rendering logic + memoized them Depends on D10279 Test Plan Confirmed that there were no regressions with the thread notificaitons modal
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptDec 8 2023, 1:55 PM2023-12-08 13:55:57 (UTC-8) Harbormaster completed remote builds in B24928: Diff 34462.Dec 8 2023, 2:18 PM2023-12-08 14:18:24 (UTC-8) This revision is now accepted and ready to land.Dec 10 2023, 5:25 PM2023-12-10 17:25:54 (UTC-8) ginsu added a child revision: D10315: [web] cleanup thread notifications modal.Dec 12 2023, 12:41 PM2023-12-12 12:41:34 (UTC-8) Harbormaster completed remote builds in B26867: Diff 37143.Feb 15 2024, 12:43 AM2024-02-15 00:43:58 (UTC-8) Closed by commit rCOMM0106682a76f7: [web] cleanup thread notifications modal rendering logic (authored by ginsu). · Explain WhyFeb 15 2024, 12:44 AM2024-02-15 00:44:03 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 37158 |